[ https://issues.apache.org/jira/browse/SOLR-13352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841533#comment-16841533 ]
ASF subversion and git services commented on SOLR-13352: -------------------------------------------------------- Commit 97bb70e73710a701abeed2997d535bc0fc98d7a5 in lucene-solr's branch refs/heads/branch_7_7 from Chris M. Hostetter [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=97bb70e ] SOLR-13352: Remove risk of deadlock/threadleak when shutting down an Overseer(TriggerThread) (cherry picked from commit 1071d093360b2c5869a918de743c7089952094f4) > possible deadlock/threadleak from OverseerTriggerThread/AutoScalingWatcher > during close() > ----------------------------------------------------------------------------------------- > > Key: SOLR-13352 > URL: https://issues.apache.org/jira/browse/SOLR-13352 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Hoss Man > Assignee: Hoss Man > Priority: Major > Fix For: 7.7.2, 8.1, master (9.0) > > Attachments: SOLR-13352.patch, > sarowe_Lucene-Solr-tests-master_20462.log.txt > > > A recent jenkins failure in TestSimTriggerIntegration lead me to what appears > to be a "lock leak" situation in OverseerTriggerThread in how the > "updateLock" object is dealt with in the event that the OverseerTriggerThread > is closed. > It's possible that this only affects tests using the SimCloudManager when > calling "simRestartOverseer" -- but > I _believe_ this can lead also lead to an actual deadlock / threadleak > situation in a thread running AutoScalingWatcher (that hold a refrefrences to > OverseerTriggerThread and every object reachable from it) when the > OverseerTriggerThread is closed as part of a real Solr shutdown ... which i > think would cause the JVM to stall untill externally killed. > ---- > If my analysis of the test failure (to follow in comment) is correct, then > even even if this bug isn't likely to affect real world solr instances (and > only surfaces because of how OverseerTriggerThread is used in > SimCloudManager) the fix to OverseerTriggerThread is a trivial change to > follow locking best practices (patch to follow) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org