[ https://issues.apache.org/jira/browse/LUCENE-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843218#comment-16843218 ]
Robert Muir commented on LUCENE-8805: ------------------------------------- Another idea: we may want to add some tests where we pass BytesRef in, and the offset is nonzero. There may be some code somewhere consuming the data only works properly when {{offset=0}}, which needs fixing. It has happened a few times before. > Parameter changes for binaryField() and stringField() in StoredFieldVisitor > --------------------------------------------------------------------------- > > Key: LUCENE-8805 > URL: https://issues.apache.org/jira/browse/LUCENE-8805 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Namgyu Kim > Priority: Major > Attachments: LUCENE-8805.patch > > > I wrote this patch after seeing the comments left by [~mikemccand] when > SortingStoredFieldsConsumer class was first created. > {code:java} > @Override > public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException > { > ... > // TODO: can we avoid new BR here? > ... > } > @Override > public void stringField(FieldInfo fieldInfo, byte[] value) throws IOException > { > ... > // TODO: can we avoid new String here? > ... > } > {code} > I changed two things. > 1) change binaryField() parameters from byte[] to BytesRef. > 2) change stringField() parameters from byte[] to String. > I also changed the related contents while doing the work. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org