[
https://issues.apache.org/jira/browse/LUCENE-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847247#comment-16847247
]
Atri Sharma commented on LUCENE-8810:
-------------------------------------
[~msauvee] I am not able to understand what is the actual issue that you are
seeing here. Given that a single Builder cannot have more than 1024 clauses,
your inner builder is erroring out which is the expected behaviour.
I am curious to think of a parallel implication here though. What is the
expected semantic when a nested disjunction which will be flattened exceeds the
total clause count, when combined with the parent boolean query? I.e. if the
parent query had 601 clauses, where one of the clauses was a disjunction
containing another 600 clauses, will this query be treated as a valid query (it
is treated as valid today). Is this the correct invariant?
> Flattening of nested disjunctions does not take into account number of clause
> limitation of builder
> ---------------------------------------------------------------------------------------------------
>
> Key: LUCENE-8810
> URL: https://issues.apache.org/jira/browse/LUCENE-8810
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/search
> Affects Versions: 8.0
> Reporter: Mickaël Sauvée
> Priority: Minor
> Fix For: 8.1.1
>
>
> In org.apache.lucene.search.BooleanQuery, at the end of the function
> rewrite(IndexReader reader), the query is rewritten to flatten nested
> disjunctions.
> This does not take into account the limitation on the number of clauses in a
> builder (1024).
> In some circumstances, this limite can be reached, hence an exception is
> thrown.
> Here is a unit test that highlight this.
> {code:java}
> public void testFlattenInnerDisjunctionsWithMoreThan1024Terms() throws
> IOException {
> IndexSearcher searcher = newSearcher(new MultiReader());
> BooleanQuery.Builder builder1024 = new BooleanQuery.Builder();
> for(int i = 0; i < 1024; i++) {
> builder1024.add(new TermQuery(new Term("foo", "bar-" + i)),
> Occur.SHOULD);
> }
> Query inner = builder1024.build();
> Query query = new BooleanQuery.Builder()
> .add(inner, Occur.SHOULD)
> .add(new TermQuery(new Term("foo", "baz")), Occur.SHOULD)
> .build();
> searcher.rewrite(query);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
