[
https://issues.apache.org/jira/browse/SOLR-12562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847808#comment-16847808
]
Erick Erickson commented on SOLR-12562:
---------------------------------------
Updated patch, if all goes well I'll commit this weekend. It incorporates (I
think) your suggestions [~dsmiley].
I looked at TestRealTimeGet and it looks like it incorporates all of the
variants, so this feels pretty solid.
Precommit and all tests pass. I'll enable patch review too.
> Clean up RealTimeGetComponent.toSolrDoc
> ---------------------------------------
>
> Key: SOLR-12562
> URL: https://issues.apache.org/jira/browse/SOLR-12562
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: SOLR-12562.patch, SOLR-12562.patch
>
>
> This code looks really redundant so we should remove one. The one in
> RealTimeGet is the only used locally so my vote is to remove that one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
