[
https://issues.apache.org/jira/browse/LUCENE-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848292#comment-16848292
]
Tomoko Uchida commented on LUCENE-8778:
---------------------------------------
Sorry, here is the diff between the master and my branch of
{{AnalysisSPILoader}}:
https://github.com/apache/lucene-solr/pull/654/files#diff-66189248b1160a3e940e33d09e7d82a8
This is the critical part that needs to be reviewed. I think I can validate all
other parts with unit tests and regression tests I attached here, before
pushing the (squash-merged) commit to the Apache gitbox .
> Define analyzer SPI names as static final fields and document the names in
> Javadocs
> -----------------------------------------------------------------------------------
>
> Key: LUCENE-8778
> URL: https://issues.apache.org/jira/browse/LUCENE-8778
> Project: Lucene - Core
> Issue Type: Task
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Priority: Minor
> Attachments: ListAnalysisComponents.java, SPINamesGenerator.java,
> Screenshot from 2019-04-26 02-17-48.png, Screenshot from 2019-05-25
> 23-25-24.png, TestSPINames.java
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Each built-in analysis component (factory of tokenizer / char filter / token
> filter) has a SPI name but currently this is not documented anywhere.
> The goals of this issue:
> * Define SPI names as static final field for each analysis component so that
> users can get the component by name (via {{NAME}} static field.) This also
> provides compile time safety.
> * Officially document the SPI names in Javadocs.
> * Add proper source validation rules to ant {{validate-source-patterns}}
> target so that we can make sure that all analysis components have correct
> field definitions and documentation
> and,
> * Lookup SPI names on the new {{NAME}} fields. Instead deriving those from
> class names.
> (Just for quick reference) we now have:
> * *19* Tokenizers ({{TokenizerFactory.availableTokenizers()}})
> * *6* CharFilters ({{CharFilterFactory.availableCharFilters()}})
> * *118* TokenFilters ({{TokenFilterFactory.availableTokenFilters()}})
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
