shalinmangar commented on a change in pull request #685: SOLR-13434: OpenTracing support for Solr URL: https://github.com/apache/lucene-solr/pull/685#discussion_r288052371
########## File path: solr/contrib/jaegertracer-configurator/README.txt ########## @@ -0,0 +1,30 @@ +Welcome to Apache Solr Prometheus Exporter +======== + +Apache Solr Jaeger Tracer Configurator (solr-jaeger-tracer) provides a way for you to expose Solr's tracing to Jaeger. + +# Setup Jaeger Tracer Configurator + +Note that all library of solr-jaeger-tracer must be included in the classpath of all nodes then Jaeger tracer can be setup in `solr.xml` like this: + +``` +<tracerConfig name="tracerConfig" class="org.apache.solr.jaeger.JaegerTracerConfigurator"> Review comment: It'd be better if we drive samplePercentage dynamically through cluster properties. Imagine wanting to change the sample percentage and having to update solr.xml in zk and restarting all nodes. It would be quite cumbersome. Also, shouldn't this be collection specific? e.g. what if I want to sample a collection more aggressively than others? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
