mikemccand commented on a change in pull request #688: LUCENE-8813: Ensure we
never apply deletes from a closed DWPTDeleteQueue
URL: https://github.com/apache/lucene-solr/pull/688#discussion_r288154648
##########
File path: lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java
##########
@@ -724,14 +727,15 @@ long flushAllThreads()
if (infoStream.isEnabled("DW")) {
infoStream.message("DW", Thread.currentThread().getName() + ": flush
naked frozen global deletes");
}
- assertTicketQueueModification(flushingDeleteQueue);
+ assert assertTicketQueueModification(flushingDeleteQueue);
Review comment:
Whoa :) I wonder if we are doing this anywhere else in Lucene!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
