[ 
https://issues.apache.org/jira/browse/SOLR-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852027#comment-16852027
 ] 

Mark Miller commented on SOLR-13501:
------------------------------------

ConcurrentUpdateHttp2SolrClient#offer(E e, long timeout, TimeUnit unit) has a 
race that can leave requests stuck  - rather than fix things like this (like 
ConcurrentUpdateSolrClient, this stuff is too complicated) I think we should 
remove this class and use Http2SolrClient like it was intended - as the client 
to replace all clients.

> Use Http2SolrClient in DUP and remove ConcurrentUpdateHttp2SolrClient.
> ----------------------------------------------------------------------
>
>                 Key: SOLR-13501
>                 URL: https://issues.apache.org/jira/browse/SOLR-13501
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Major
>             Fix For: 8.2
>
>
> One of the great things about Http2SolrClient is that it removes the need for 
> the complicated and trappy ConcurrentUpdateSolrServer. The Jetty HttpClient 
> already has queues and handles all of this stuff better than we do.
> DUP should be using async and Http2SolrClient and now properly handling 
> errors and such for the first time, unless I am missing something ...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to