[ https://issues.apache.org/jira/browse/SOLR-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Juan Grande updated SOLR-2280: ------------------------------ Attachment: SOLR-2280.patch I'm submitting a patch that implements commitWithin on deletes. The patch is for the 3x branch. Two things should be noted: # The commit is fired even if the delete doesn't really delete any document. # When using the BinaryUpdateRequestHandler the params of the UpdateRequest are loaded when parsing the docs. If the request doesn't include a docs list, then the params aren't loaded. I added a workaround for this, but SOLR-1164 should solve this problem definitely. > commitWithin ignored for a delete query > --------------------------------------- > > Key: SOLR-2280 > URL: https://issues.apache.org/jira/browse/SOLR-2280 > Project: Solr > Issue Type: Bug > Components: clients - java > Reporter: David Smiley > Priority: Minor > Fix For: 3.4, 4.0 > > Attachments: SOLR-2280.patch > > > The commitWithin option on an UpdateRequest is only honored for requests > containing new documents. It does not, for example, work with a delete > query. The following doesn't work as expected: > {code:java} > UpdateRequest request = new UpdateRequest(); > request.deleteById("id123"); > request.setCommitWithin(1000); > solrServer.request(request); > {code} > In my opinion, the commitWithin attribute should be permitted on the > <delete/> xml tag as well as <add/>. Such a change would go in > XMLLoader.java and its would have some ramifications elsewhere too. Once > this is done, then UpdateRequest.getXml() can be updated to generate the > right XML. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org