janhoy commented on a change in pull request #702: LUCENE-8837
smokeTestRelease.py option --download-only
URL: https://github.com/apache/lucene-solr/pull/702#discussion_r291398726
##########
File path: dev-tools/scripts/scriptutil.py
##########
@@ -66,14 +70,19 @@ def on_or_after(self, other):
(self.bugfix > other.bugfix or self.bugfix == other.bugfix and
self.prerelease >= other.prerelease)))
+ def gt(self, other):
+ return (self.major > other.major or
+ (self.major == other.major and self.minor > other.minor) or
+ (self.major == other.major and self.minor == other.minor and
self.bugfix > other.bugfix))
+
def is_back_compat_with(self, other):
if not self.on_or_after(other):
raise Exception('Back compat check disallowed for newer version: %s <
%s' % (self, other))
return other.major + 1 >= self.major
-def run(cmd):
+def run(cmd, cwd=None):
Review comment:
Support for cwd in the run command is useful so that the cmd can be relative
to some folder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
