[
https://issues.apache.org/jira/browse/LUCENE-8845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860006#comment-16860006
]
Atri Sharma commented on LUCENE-8845:
-------------------------------------
Patch looks good and a useful change!
Here are some minor comments:
1) Should we mark the new method as expert?
2) Should we still have a "hard" cap on the number of expansions we can
support? It would be prudent to have a limit to ensure that users do not
specify too high a limit and then see unexpected and drastic changes to
latencies?
3) There is a change in the check for number of terms vs max number of terms
allowed (theincrement happens before the check of max terms vs after). Is that
something that is unrelated to this change, but a general accuracy improvement?
> Allow maxExpansions to be set on multi-term Intervals
> -----------------------------------------------------
>
> Key: LUCENE-8845
> URL: https://issues.apache.org/jira/browse/LUCENE-8845
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Major
> Attachments: LUCENE-8845.patch
>
>
> MultiTermIntervalsSource has a maxExpansions parameter which is always set to
> 128 by the factory methods Intervals.prefix() and Intervals.wildcard(). We
> should keep 128 as the default, but also add additional methods that take a
> configurable maximum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
