gerlowskija commented on issue #665: Fixes SOLR-13539 URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-501332356 I agree with Jan's complaints about IDE-triggered changes in this PR btw. The `w=1` trick is a cool one to know, but reviews are still made tougher when there is noise from re-organized imports, `final` addition/removal, etc. Look out for this in subsequent commits if you can. If our ant targets produce IDE configs that trigger these reformattings as automatic save actions, we'll have to fix that. Thanks for bringing it up.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org