[ https://issues.apache.org/jira/browse/LUCENE-8847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867320#comment-16867320 ]
ASF subversion and git services commented on LUCENE-8847: --------------------------------------------------------- Commit 7c5247c60c4461a4817f4de942a7a18d892e8243 in lucene-solr's branch refs/heads/master from Adrien Grand [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7c5247c ] LUCENE-8847: Fix typo in CHANGES. > Code Cleanup: Rewrite StringBuilder.append with concatted strings > ----------------------------------------------------------------- > > Key: LUCENE-8847 > URL: https://issues.apache.org/jira/browse/LUCENE-8847 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Koen De Groote > Assignee: Uwe Schindler > Priority: Trivial > Fix For: master (9.0), 8.2 > > > EDIT: Again, to clarify, please don't bother yourself with this ticket on > company time, on personal time you could be working on something that makes > you money or improves the product for your feature personally. > > This entire ticket is an afterthough. A look back at the code base that most > people don't have the time for. > --------- > > Code cleanup as suggested by static analysis tools. Will be done in my spare > time. > If someone reviews this, please also do not take up actual time from your > work to do that. I do not wish to take away from your working hours. > > These are simple, trivial things, that were probably overlooked or not even > considered(which isn't an accusation or something negative). But also stuff > that the Java compiler/JIT won't optimize on its own. > > That's what static analysis tool are good for: picking stuff like that up. > > I'm talking about Intellij's static code analysis. Facebook's "Infer" for > Java. Google's "errorprone", etc... > These are the kinds of things that, frankly, for the people actually working > on real features, are very time consuming, not even part of the feature, and > have a very low chance of actually turning up a real performance issue. > So I'm opting to have a look at the results of these tools and implementing > the sensible stuff and if something bigger pops up I'll make a separate > ticket for those things individually. > > Creating this ticket so I can name a branch after it. > > The only questions I have are: since the code base is so large, do I apply > each subject to all parts of it? Or only core? How do I split it up? > Do I make multiple PRs with this one ticket? Or do I make multiple tickets > and give each their own PR? -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org