mocobeta commented on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-504019096 Hi, just from curiosity I've googled for a while if we can handle case insensitive lookup with LinkedHashMap so that we don't need extra Set object for reference. There are (not very attractive) two options: 1. Create a special Map implementation which preserves insert order and also provides case insensitive lookup 2. Create a special class which holds a String (service name) and has case-insensitive hashCode() and equals() I think both are somewhat over-engineering for the use case here, so current implementation seems like an appropriate solution. Any comments?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
