msokolov opened a new pull request #739: LUCENE-8871: promote kuromoji tools to main jar URL: https://github.com/apache/lucene-solr/pull/739 * move Kuromoji tools to main build path ** code cleanup When doing this, it became necessary to bring the code up to a different standard to satisfy forbidden-apis, so I took an opportunity to modernize it and follow various suggestions from IntelliJ. *** replace use of java.io.File with java.nio *** change the internal file-related APIs to use Path instead of String *** Use try-with-resources for all the streams and readers *** Sprinkle streams and lambdas around Just to make the code briefer, and IMO easier to read *** removed print statements *** reduced visibility of methods as much as possible ** remove build-tools stuff from build.xml ** functional changes *** exception when an invalid format is specified instead of defaulting to unidic *** exception when a bad dictionary entry is encountered instead of printing a message and soldiering on ** testing *** precompile, test *** also built dictionary verified files are unchanged except for FST version number
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
