[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872532#comment-16872532 ]
Adrien Grand commented on LUCENE-8855: -------------------------------------- BytesRefHash has some code commented out that looks like a left over? One minor last concern I have is that sizeOf without a default size feels a bit trappy since lots of objects are larger than their shallow size. Could we make it fail if it encounters an unknown object instead of assuming shallow size? > Add Accountable to Query implementations > ---------------------------------------- > > Key: LUCENE-8855 > URL: https://issues.apache.org/jira/browse/LUCENE-8855 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Andrzej Bialecki > Assignee: Andrzej Bialecki > Priority: Major > Attachments: LUCENE-8855.patch, LUCENE-8855.patch, LUCENE-8855.patch, > LUCENE-8855.patch > > > Query implementations should also support {{Accountable}} API in order to > monitor the memory consumption e.g. in caches where either keys or values are > {{Query}} instances. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org