nknize commented on a change in pull request #726: LUCENE-8632: New XYShape Field and Queries for indexing and searching general cartesian geometries URL: https://github.com/apache/lucene-solr/pull/726#discussion_r297775564
########## File path: lucene/sandbox/src/test/org/apache/lucene/document/TestXYShape.java ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.document; + +import org.apache.lucene.document.ShapeField.QueryRelation; +import org.apache.lucene.geo.XYLine; +import org.apache.lucene.geo.XYPolygon; +import org.apache.lucene.index.IndexReader; +import org.apache.lucene.index.RandomIndexWriter; +import org.apache.lucene.search.IndexSearcher; +import org.apache.lucene.search.Query; +import org.apache.lucene.store.Directory; +import org.apache.lucene.util.IOUtils; +import org.apache.lucene.util.LuceneTestCase; + +/** Test case for indexing cartesian shapes and search by bounding box, lines, and polygons */ +public class TestXYShape extends LuceneTestCase { + + protected static String FIELDNAME = "field"; + protected void addPolygonsToDoc(String field, Document doc, XYPolygon polygon) { + Field[] fields = XYShape.createIndexableFields(field, polygon); + for (Field f : fields) { + doc.add(f); + } + } + + protected Query newRectQuery(String field, double minX, double maxX, double minY, double maxY) { + return XYShape.newBoxQuery(field, QueryRelation.INTERSECTS, minX, maxX, minY, maxY); + } + + /** test we can search for a point with a standard number of vertices*/ + public void testBasicIntersects() throws Exception { +// int numVertices = TestUtil.nextInt(random(), 50, 100); + Directory dir = newDirectory(); + RandomIndexWriter writer = new RandomIndexWriter(random(), dir); + + // add a random polygon document +// Polygon p = GeoTestUtil.createRegularPolygon(0, 90, atLeast(1000000), numVertices); +// XYPolygon xyp = new XYPolygon(p.getPolyLons(), p.getPolyLats(), XYShape.XYShapeType.INTEGER); Review comment: Kind of... I went back and made this test slightly more randomized... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
