[ https://issues.apache.org/jira/browse/LUCENE-8871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873980#comment-16873980 ]
Adrien Grand commented on LUCENE-8871: -------------------------------------- [~sokolov] I tried to address the precommit failures but this required some changes to the visibility of classes, could you review? > Move Kuromoji DictionaryBuilder tool from src/tools to src/ > ------------------------------------------------------------ > > Key: LUCENE-8871 > URL: https://issues.apache.org/jira/browse/LUCENE-8871 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Mike Sokolov > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently tests in tools directories are not run as part of the normal > testing done by {{ant test}} - you have to explicitly run {{test-tools}}, > which it seems people don't do (and it might not survivie translation to > gradle, who knows), so [~rcmuir] suggested we just move the tools into the > main source tree (under src/java and src/test) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org