jpountz commented on a change in pull request #746: LUCENE-8885: Optimise BKD
reader by exploiting cardinality information stored on leaves
URL: https://github.com/apache/lucene-solr/pull/746#discussion_r298139661
##########
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##########
@@ -208,6 +208,15 @@ protected PointValues() {
* docID order. */
void visit(int docID, byte[] packedValue) throws IOException;
+ /** Similar to {@link IntersectVisitor#visit(int, byte[])} but in this
case the packedValue
+ * can have more than one docID associated to it. */
Review comment:
Can you document that the iterator should not escape the scope of this
method so that implementations of PointValues are free to reuse the iterator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
