[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874965#comment-16874965 ]
Tomoko Uchida edited comment on LUCENE-8891 at 6/28/19 2:42 PM: ---------------------------------------------------------------- Thanks [~gpaimla], the patch looks fine to me. I noticed a few small things: - "precommit" task is failed because of there remain unused import statements. We have various code and documentation linters / rules which should be checked before committing changes to the master. You can run the checks by executing {{ant precommit}}. - It is common convention to create one test class for each class to be tested. {{TestEstonianStemming}} seems slightly odd to me since there is no class named {{EstonianStemming}}. I think it can be merged into {{TestEstonianAnalyzer}}, opinions? was (Author: tomoko uchida): Thanks [~gpaimla], the patch looks fine to me. I noticed a few small things: - "precommit" task is failed because of there remain unused import statements. We have various code and documentation linters / rules which should be checked before committing changes to the master. You can run the checks by executing {{ant precommit}}. - It is common convention to create one test class for each class to be tested. {{TestEstonianStemming}} seems slightly odd to me since there are not {{EstonianStemming}} class. I think it can be merged into {{TestEstonianAnalyzer}}, opinions? > Snowball stemmer/analyzer for the Estonian language > --------------------------------------------------- > > Key: LUCENE-8891 > URL: https://issues.apache.org/jira/browse/LUCENE-8891 > Project: Lucene - Core > Issue Type: New Feature > Components: modules/analysis > Reporter: Gert Morten Paimla > Priority: Minor > Labels: newbie, ready-to-commit > Attachments: LUCENE-8891.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Currently there is no Estonian specific stemmer for SnowballFilter. > I would like to add a Snowball stemmer for the Estonian language and also add > a new Language analyzer for the Estonian language based on the snowball > stemmer. > [https://github.com/gpaimla/lucene-solr] fork of master branch with the > analyzer implemented -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org