mocobeta opened a new pull request #752: LUCENE-8894: Add APIs to look up SPI name for a concrete factory class URL: https://github.com/apache/lucene-solr/pull/752 # Description Currently, reflection tricks are needed to obtain SPI name (this is now stored in static NAME fields in each factory class) from a concrete factory class. While it is easy to implement that logic, it would be much better to provide unified APIs to get SPI name for tokenizer/charfilter/tokenfilter factory classes. # Solution Add public static APIs which are signatured `String findSPIName(Class)` to `TokenizerFactory`, `CharFilterFactory`, and `TokenFilterFactory`. # Tests See `o.a.l.a.util.TestAbstractAnalysisFactory`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute. - [x] I have developed this patch against the `master` branch. - [x] I have run `ant precommit` and the appropriate test suite. - [x] I have added tests for my changes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
