jpountz commented on issue #754: LUCENE-8875: Introduce Optimized Collector For Large Number Of Hits URL: https://github.com/apache/lucene-solr/pull/754#issuecomment-509595902 > Too bad we cannot share any (of this complex) code with existing collectors The initial PR tried to share some logic, but I suggested to avoid doing this as I was expecting this collector to work fairly differently given that it operates on different assumptions. Looking at the current code, it doesn't seem to be like there is a lot to be shared? > I am surprised that the test is failing : it seems to be consistently passing for me. I ran a couple of times. I identified the bug, it was due to collecting `doc` instead of `docBase+doc` when collecting into an ArrayList. Maybe there is something to be refactored in the test so that it would have surfaced this issue more consistently?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
