[ 
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881908#comment-16881908
 ] 

jia yang commented on SOLR-5837:
--------------------------------

 
[https://svn.apache.org/viewvc/lucene/dev/branches/branch_4x/solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java?view=markup&pathrev=1577500]
    

I find  SolrTestCaseJ4.java with a bug . assertSolrDocumentEquals  method  1873 
row .  if solr result  Is disordered,then 

!key1.equals(key2) must be true . 

so i repair:

String key1 = iter1.next();


Object val1 = solrDocument1.getFieldValues(key1);

Object val2 = solrDocument2.getFieldValues(key1);

if (!val1.equals(val2)) {
 return false;
}

 

> Add missing equals implementation for SolrDocument, SolrInputDocument and 
> SolrInputField.
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-5837
>                 URL: https://issues.apache.org/jira/browse/SOLR-5837
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Varun Thacker
>            Assignee: Noble Paul
>            Priority: Major
>         Attachments: SOLR-5837.patch, SOLR-5837.patch
>
>
> While working on SOLR-5265 I tried comparing objects of SolrDocument, 
> SolrInputDocument and SolrInputField. These classes did not Override the 
> equals implementation. 
> The issue will Override equals and hashCode methods to the 3 classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to