munendrasn commented on a change in pull request #597: [SOLR-13272] feat(facet/interval): support json facet requests for interval facet URL: https://github.com/apache/lucene-solr/pull/597#discussion_r303986989
########## File path: solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java ########## @@ -3225,6 +3224,58 @@ public void testDomainErrors() throws Exception { } + @Test + public void testIntervalFacets() throws Exception { Review comment: Please add test cases to cover `other`, `include` and refinement ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org