[ 
https://issues.apache.org/jira/browse/SOLR-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102990#comment-13102990
 ] 

Martijn van Groningen commented on SOLR-2756:
---------------------------------------------

+1 The lucene-core dependency should be removed. Solr is Java 1.6, so 
geronimo-stax-api and wstx-asl can also be removed.
In the trunk there is SolrCloud code in the commons.cloud package. I'm not sure 
why this is put in the solrj source tree.
In the 3x the zookeeper can be removed.

> SolrJ maven dependencies are faulty; needless dependency on lucene-core
> -----------------------------------------------------------------------
>
>                 Key: SOLR-2756
>                 URL: https://issues.apache.org/jira/browse/SOLR-2756
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 3.3
>            Reporter: David Smiley
>            Priority: Minor
>
> I included a SolrJ 3.3 dependency into a new project and I noticed needless 
> dependencies transitive show up.
> Here is a subset of the output from mvn dependency:tree:
> {noformat}
> [INFO] +- org.apache.solr:solr-solrj:jar:3.3.0:compile
> [INFO] |  +- org.apache.lucene:lucene-core:jar:3.3.0:compile
> [INFO] |  +- commons-httpclient:commons-httpclient:jar:3.1:compile
> [INFO] |  |  \- commons-codec:commons-codec:jar:1.2:compile
> [INFO] |  +- 
> org.apache.geronimo.specs:geronimo-stax-api_1.0_spec:jar:1.0.1:compile
> [INFO] |  +- org.apache.zookeeper:zookeeper:jar:3.3.1:compile
> [INFO] |  |  +- log4j:log4j:jar:1.2.15:compile
> [INFO] |  |  |  \- javax.mail:mail:jar:1.4:compile
> [INFO] |  |  |     \- javax.activation:activation:jar:1.1:compile
> [INFO] |  |  \- jline:jline:jar:0.9.94:compile
> [INFO] |  \- org.codehaus.woodstox:wstx-asl:jar:3.2.7:compile
> [INFO] |     \- stax:stax-api:jar:1.0.1:compile
> {noformat}
> Clearly there is an inconsistency with solr/dist/solrj-lib and this list.
> * lucene-core dependency should be removed
> * AFAIK, geronimo-stax-api and wstx-asl are only needed for Java 1.5.  Right? 
>  These can be put in a maven profile activated by jdk1.5.
> * zookeeper dependency should be removed. Is this used in Solr 4?  Even if it 
> is, it strikes me as an optional dependency.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to