janhoy commented on a change in pull request #804: SOLR-13647 default solr.in.sh contains uncommented lines URL: https://github.com/apache/lucene-solr/pull/804#discussion_r306247783
########## File path: solr/bin/solr.in.sh ########## @@ -82,7 +82,7 @@ # Set to true to activate the JMX RMI connector to allow remote JMX client applications # to monitor the JVM hosting Solr; set to "false" to disable that behavior # (false is recommended in production environments) -ENABLE_REMOTE_JMX_OPTS="true" +# ENABLE_REMOTE_JMX_OPTS="true" Review comment: Actually the commented text should say "false" as it was in 8.0. Commented defaults should reflect the implicit defaults. Can you fix? Please also add a CHANGES.TXT entry about the fix. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
