atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal Arguments URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-515451533 I looked at the testGrouping failure -- looks like the test assumes that the second pass collector will always collect atleast docsInGroup hits, and thus takes a random offset there to start with. However, that is not always true, and the number of hits collected can be lesser. I think the ideal way of usage of topDocs is to get the totalHits from the corresponding TopDocsCollector and use that as the fence to set the starting point.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
