[ 
https://issues.apache.org/jira/browse/LUCENE-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16894394#comment-16894394
 ] 

Tomoko Uchida commented on LUCENE-8936:
---------------------------------------

Hi [~vinod1812],

the patch looks fine. Actually I cannot review the {{SpanishMinimalStemmer}} 
class (I don't understand Spanish), but other parts looks okay to me. And this 
passed {{ant precommit}} (thanks!).

I will commit it after waiting 24 hours if there are no other comments.

 

About the github PR, only the Lucene/Solr committers have the write permission 
to the apache/lucene-solr repo. So you have to fork the repo and open a pull 
request. But this time, a patch has been provided so you do not need to do so.

> Add SpanishMinimalStemFilter
> ----------------------------
>
>                 Key: LUCENE-8936
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8936
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: vinod kumar
>            Priority: Major
>         Attachments: LUCENE-8936.patch
>
>
> SpanishMinimalStemmerFilter is less aggressive stemmer than 
> SpanishLightStemmerFilter
> Ex:
> input tokens -> output tokens
>  1. camiseta niños -> *camiseta* and *nino*
>  2. camisas -> camisa
> *camisetas* and *camisas* are t-shirts and shirts respectively.
>  Stemming both of the tokens to *camis* will match both tokens and returns 
> both t-shirts and shirts for query camisas(shirts). 
> SpanishMinimalStemmerFilter will help handling these cases.
> And importantly It will preserve gender context with tokens.
> Ex:  *niños* ,*niñas* *chicos* and *chicas* are stemmed to *nino*, *nina*, 
> *chico* and *chica*



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to