[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16900066#comment-16900066 ]
Tomoko Uchida commented on SOLR-13593: -------------------------------------- Thanks [~dsmiley], I agree with you. I will update the PR so the property check will be: * when neither "name" nor "class" is passed : an exception is thrown. * when both of "name" and "class" are passed: an exception is thrown. * when only "name" is passed: it's accepted. * when only "class" is specified: it's accepted for backwards compatibility. (maybe we should deprecate this and emit some warnings, after default schema is changed.) > Allow to specify analyzer components by their SPI names in schema definition > ---------------------------------------------------------------------------- > > Key: SOLR-13593 > URL: https://issues.apache.org/jira/browse/SOLR-13593 > Project: Solr > Issue Type: Improvement > Components: Schema and Analysis > Reporter: Tomoko Uchida > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Now each analysis factory has explicitely documented SPI name which is stored > in the static "NAME" field (LUCENE-8778). > Solr uses factories' simple class name in schema definition (like > class="solr.WhitespaceTokenizerFactory"), but we should be able to also use > more concise SPI names (like name="whitespace"). > e.g.: > {code:xml} > <fieldtype name="myfieldtype" class="solr.TextField"> > <analyzer> > <tokenizer class="solr.WhitespaceTokenizerFactory"/> > <filter class="solr.KeywordMarkerFilterFactory" protected="protwords.txt" > /> > <filter class="solr.PorterStemFilterFactory" /> > </analyzer> > </fieldtype> > {code} > would be > {code:xml} > <fieldtype name="myfieldtype" class="solr.TextField"> > <analyzer> > <tokenizer name="whitespace"/> > <filter name="keywordMarker" protected="protwords.txt" /> > <filter name="porterStem" /> > </analyzer> > </fieldtype> > {code} -- This message was sent by Atlassian JIRA (v7.6.14#76016) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org