[
https://issues.apache.org/jira/browse/SOLR-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901172#comment-16901172
]
Andrzej Bialecki commented on SOLR-13677:
------------------------------------------
Thanks Christine, this looks somewhat cleaner.
For historical reasons (a complicated refactoring of SolrInfoMBean, UI
dependencies, JMX, etc) some of the methods one would expect from
{{SolrMetricProducer}} ended up in {{SolrInfoBean}} instead, and this is also
the interface that is passed to {{registerGauge}}. Unless we want to do a
larger refactoring now, we could treat {{SolrInfoBean}} as the memory, and add
the default methods for remembering and forgetting the gauges to this interface.
> All Metrics Gauges should be unregistered by the objects that registered them
> -----------------------------------------------------------------------------
>
> Key: SOLR-13677
> URL: https://issues.apache.org/jira/browse/SOLR-13677
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: metrics
> Reporter: Noble Paul
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The life cycle of Metrics producers are managed by the core (mostly). So, if
> the lifecycle of the object is different from that of the core itself, these
> objects will never be unregistered from the metrics registry. This will lead
> to memory leaks
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
