[
https://issues.apache.org/jira/browse/SOLR-13539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904660#comment-16904660
]
Jason Gerlowski commented on SOLR-13539:
----------------------------------------
bq. To be honest, this whole situation with the javabin change is getting
confusing, with various partial fixes
I agree, the situation has become quite confused. Partially to blame is my
slowness in reviewing some of Thomas' PRs. Also contributing is that this bug
was found and reported in a handful of different JIRAs, each reporting various
levels of progress and not kept up to date.
(This is worth apologizing again for: I thought tags on github PRs were making
it through my email filters, but apparently not. My inattention on Thomas'
PR's is embarassing. Sorry Thomas. I'm glad you tagged me on jira.)
So let's try to clarify. My understanding is that all of the atomic-update
ByteArrayUtf8CharSequence cast issues have been fixed on {{master}} and
{{branch_8x}}. All the remaining open PRs are test improvements. Thomas has
two PR's open: PR #665 and PR #755. It looks to me like #665 depends on #755
(755 introduces a new test-base, 665 changes some existing tests to use this
new class). And Tim has proposed some additional unit tests in SOLR-9505 (as
well as suggesting a change to our documentation). At a glance both of these
sets of test changes are complimentary to each other, and we can merge both of
them after review.
Does that match your understanding of things [~thomas.woeckinger]?
bq. it's not clear to me which fixes are on the 7.x branch. Right now, 7.7.2
standard is effectively broken.
Thomas is right- I haven't made an attempt to backport this to the 7x code
line. Primarily because I don't expect any more 7x releases. There might be a
7.7.3 if some serious security issue is found, but even in that case the aim
would be to introduce as little change into 7.7.3 as possible, and only fix the
security issue itself. I can make a case for backporting if a 7.7.3 comes up,
but there might be pushback depending on the release manager.
> Atomic Update Multivalue remove does not work for field types UUID, Enums,
> Bool and Binary
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-13539
> URL: https://issues.apache.org/jira/browse/SOLR-13539
> Project: Solr
> Issue Type: Bug
> Components: UpdateRequestProcessors
> Affects Versions: 7.7.2, 8.1, 8.1.1
> Reporter: Thomas Wöckinger
> Priority: Critical
> Attachments: SOLR-13539.patch
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> When using JavaBinCodec the values of collections are of type
> ByteArrayUtf8CharSequence, existing field values are Strings so the remove
> Operation does not have any effect.
> This is related to following field types: UUID, Enums, Bool and Binary
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
