magibney commented on a change in pull request #677: SOLR-13257: support for
stable replica routing preferences
URL: https://github.com/apache/lucene-solr/pull/677#discussion_r313402997
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
##########
@@ -230,7 +288,23 @@ public void init(PluginInfo info) {
this.accessPolicy = getParameter(args, INIT_FAIRNESS_POLICY,
accessPolicy,sb);
this.whitelistHostChecker = new WhitelistHostChecker(args == null? null:
(String) args.get(INIT_SHARDS_WHITELIST), !getDisableShardsWhitelist());
log.info("Host whitelist initialized: {}", this.whitelistHostChecker);
-
+
+ this.httpListenerFactory = new
InstrumentedHttpListenerFactory(this.metricNameStrategy);
+ int connectionTimeout = getParameter(args,
HttpClientUtil.PROP_CONNECTION_TIMEOUT,
+ HttpClientUtil.DEFAULT_CONNECT_TIMEOUT, sb);
+ int maxConnectionsPerHost = getParameter(args,
HttpClientUtil.PROP_MAX_CONNECTIONS_PER_HOST,
+ HttpClientUtil.DEFAULT_MAXCONNECTIONSPERHOST, sb);
+ int soTimeout = getParameter(args, HttpClientUtil.PROP_SO_TIMEOUT,
+ HttpClientUtil.DEFAULT_SO_TIMEOUT, sb);
+
+ this.defaultClient = new Http2SolrClient.Builder()
+ .connectionTimeout(connectionTimeout)
+ .idleTimeout(soTimeout)
+ .maxConnectionsPerHost(maxConnectionsPerHost).build();
+ this.defaultClient.addListenerFactory(this.httpListenerFactory);
+ this.loadbalancer = new LBHttp2SolrClient(defaultClient);
+ initReplicaListTransformers(getParameter(args, "replicaRouting", null,
sb));
+
log.debug("created with {}",sb);
Review comment:
Yes, this would definitely be better. There's no reason for the "created"
logging statement to be in the middle of the method, and in fact its being
there initially is what nearly caused me to bypass it with the additions in
this patch! Just pushed a commit to address this, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
