[
https://issues.apache.org/jira/browse/SOLR-13711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913635#comment-16913635
]
Christine Poerschke commented on SOLR-13711:
--------------------------------------------
Looking at the current
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.2.0/solr/core/src/java/org/apache/solr/search/grouping/distributed/command/QueryCommand.java#L97-L103
implementation:
* the sort member is final
* the QueryCommand constructor is private
* the QueryCommand.Builder.build method rejects null sort values.
Therefore the sort value cannot be null and the create and result methods can
be (slightly) simplified to not consider null-ness.
Will attach proposed patch. Reviews, questions, comments, etc. welcome as
usual. Thank you.
> remove dead sort==null code paths in QueryCommand.java
> ------------------------------------------------------
>
> Key: SOLR-13711
> URL: https://issues.apache.org/jira/browse/SOLR-13711
> Project: Solr
> Issue Type: Wish
> Reporter: Christine Poerschke
> Priority: Minor
>
> This ticket proposes to remove 'dead' QueryCommand.java paths associated with
> a 'null' sort value.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
