tflobbe commented on a change in pull request #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#discussion_r316982623
########## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Variable.java ########## @@ -297,7 +296,7 @@ private Number readNum(double v) { Set<String> readSet(String[] vals) { if (NULL.equals(vals[0])) return emptySet(); - return unmodifiableSet(new HashSet<>(Arrays.asList(vals))); + return Set.copyOf(Arrays.asList(vals)); Review comment: Also this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org