atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524185726 @tflobbe Thanks. I was slightly unsure about whether these sections actually need an immutable copy of the original set (by their usage patterns), hence was being conservative by doing copyOf instead of of(). However, post your comment, I looked at the call sites of these methods and they look to be fine with an immutable reference, so changed the calls.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
