[
https://issues.apache.org/jira/browse/LUCENE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105458#comment-13105458
]
Robert Muir commented on LUCENE-3436:
-------------------------------------
Hi James, thanks for this work!
I agree, I think we should do this refactoring (and backport to 3.x so we can
nuke the deprecations from trunk).
only one thing, can we fix the indentation in the patch?
In general we use 2 spaces (not tabs) and spaces after if keyword, etc
so instead of:
{noformat}
if(suggestMode==SuggestMode.SUGGEST_ALWAYS)
{
ir = null;
field = null;
}
{noformat}
{noformat}
if (suggestMode == SuggestMode.SUGGEST_ALWAYS) {
ir = null;
field = null;
}
{noformat}
for some of the IDEs (I dont know what editor you use?) we have style
configurations: there are some links to these configuration files
located here: http://wiki.apache.org/lucene-java/HowToContribute
Thanks again!
> Spellchecker "Suggest Mode" Support
> -----------------------------------
>
> Key: LUCENE-3436
> URL: https://issues.apache.org/jira/browse/LUCENE-3436
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/spellchecker
> Affects Versions: 3.3, 4.0
> Reporter: James Dyer
> Priority: Minor
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3436.patch
>
>
> This is a spin-off from SOLR-2585.
> Currently o.a.l.s.s.SpellChecker and o.a.l.s.s.DirectSpellChecker support two
> "Suggest Modes":
> 1. Suggest for terms that are not in the index.
> 2. Suggest "more popular" terms.
> This issue is to add a third Suggest Mode:
> 3. Suggest always.
> This will assist users in developing context-sensitive spell suggestions
> and/or did-you-mean suggestions. See SOLR-2585 for a full discussion.
> Note that o.a.l.s.s.SpellChecker already can support this functionality, if
> the user passes in a NULL term & IndexReader. This, however, is not
> intutive. o.a.l.s.s.DirectSpellChecker currently has no support for this
> third Suggest Mode.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
