janhoy commented on a change in pull request #805: SOLR-13649 change the 
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318414048
 
 

 ##########
 File path: 
solr/core/src/test/org/apache/solr/security/AuditLoggerIntegrationTest.java
 ##########
 @@ -275,7 +275,7 @@ private void assertThreeAdminEvents() throws Exception {
 
   private static String AUTH_SECTION = ",\n" +
       "  \"authentication\":{\n" +
-      "    \"blockUnknown\":\"false\",\n" +
+      "    \"blockUnknown\":\"true\",\n" +
 
 Review comment:
   Why does this explicit setting need to change? I cannot see that it changes 
anything elsewhere in the test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to