jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318559370
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
##########
@@ -297,10 +309,12 @@ public void collect(int doc) throws IOException {
// internal versions. If someone will define a constructor with any other
// visibility, then anyone will be able to extend the class, which is not
what
// we want.
- private TopFieldCollector(FieldValueHitQueue<Entry> pq, int numHits, int
totalHitsThreshold, boolean needsScores) {
+ private TopFieldCollector(FieldValueHitQueue<Entry> pq, int numHits, int
totalHitsThreshold,
Review comment:
We don't need the `totalHitsThreshold` if we have the `hitsThresholdChecker`
below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
