gus-asf commented on a change in pull request #838: SOLR-13705 Double-checked
locking bug is fixed.
URL: https://github.com/apache/lucene-solr/pull/838#discussion_r321050511
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/SecurityConfHandler.java
##########
@@ -303,11 +306,11 @@ public String toString() {
}
});
- this.apis = ImmutableList.copyOf(apis);
+ syncedApis = ImmutableList.copyOf(syncedApis);
Review comment:
Shouldn't this be assigning to this.apis so that we don't have to do this
work and create a new list every time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
