[ 
https://issues.apache.org/jira/browse/SOLR-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106512#comment-13106512
 ] 

Steven Rowe commented on SOLR-2540:
-----------------------------------

Hi Jan,

Both the trunk and the branch_3x Jenkins Maven builds failed last night because 
the Maven configuration for the {{solr/contrib/extraction/}} module does not 
depend on solr-core test code, and you just introduced a new solr-core test 
class {{BufferingRequestProcessor}}, as well as test code in Solr Cell that 
uses this class.  

(BTW, none of the other Solr modules depend on Solr test code in the Maven 
configuration.)

Apparently the Ant build system still includes solr-core test classes in the 
test classpath of the other Solr modules.  I think this should be fixed; Solr's 
test-framework makes this dependency obsolete.

In the short term, though, can we move the new {{BufferingRequestProcessor}} 
class from {{solr/core/src/test}} to {{solr/test-framework/src/java/}}?  That 
way, the Maven stuff will work again without having to jump through hoops like 
publishing a solr-core test jar and making other modules have a test dependency 
on it (that's the way it worked pre-test-framework).

> CommitWithin as an Update Request parameter
> -------------------------------------------
>
>                 Key: SOLR-2540
>                 URL: https://issues.apache.org/jira/browse/SOLR-2540
>             Project: Solr
>          Issue Type: New Feature
>          Components: update
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: commit, commitWithin
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2540-branch_3x-fix-tests.patch, 
> SOLR-2540-fix-tests.patch, SOLR-2540.patch, SOLR-2540.patch
>
>
> It would be useful to support commitWithin HTTP GET request param on all 
> UpdateRequestHandlers.
> That way, you could set commitWithin on the request (for XML, JSON, CSV, 
> Binary and Extracting handlers) with this syntax:
> {code}
>   curl 
> http://localhost:8983/solr/update/extract?literal.id=123&commitWithin=10000
>        -H "Content-Type: application/pdf" --data-binary @file.pdf
> {code}
> PS: The JsonUpdateRequestHandler and BinaryUpdateRequestHandler already 
> support this syntax.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to