nknize commented on a change in pull request #771: LUCENE-8620: Update 
Tessellator logic to label if triangle edges belongs to the original polygon
URL: https://github.com/apache/lucene-solr/pull/771#discussion_r321719788
 
 

 ##########
 File path: lucene/sandbox/src/java/org/apache/lucene/geo/Tessellator.java
 ##########
 @@ -979,9 +1118,11 @@ public String toString() {
   /** Triangle in the tessellated mesh */
   public final static class Triangle {
     Node[] vertex;
+    boolean[] edgeFromPolygon;
 
-    protected Triangle(Node a, Node b, Node c) {
+    protected Triangle(Node a, boolean abFromPolygon, Node b, boolean 
bcFromPolygon, Node c, boolean caFromPolygon) {
 
 Review comment:
   ```suggestion
       protected Triangle(Node a, boolean isABfromPolygon, Node b, boolean 
isBCfromPolygon, Node c, boolean isCAfromPolygon) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to