[ 
https://issues.apache.org/jira/browse/SOLR-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924463#comment-16924463
 ] 

Hoss Man commented on SOLR-13728:
---------------------------------


Huh?

No i'm directly refering to Commit c8203e4787b8ad21e1270781ba4e09fd7f3acb00 ...

{noformat}
hossman@slate:~/lucene/dev [j11] [master] $ git co 
c8203e4787b8ad21e1270781ba4e09fd7f3acb00 && ant clean && cd solr/core/ && ant 
test -Dtestcase=AtomicUpdateProcessorFactoryTest
...
   [junit4]   2> NOTE: Linux 5.0.0-27-generic amd64/AdoptOpenJDK 11.0.4 
(64-bit)/cpus=8,threads=2,free=199278080,total=522190848
   [junit4]   2> NOTE: All tests run in this JVM: 
[AtomicUpdateProcessorFactoryTest]
   [junit4]   2> NOTE: reproduce with: ant test  
-Dtestcase=AtomicUpdateProcessorFactoryTest -Dtests.seed=9CA837338CB8D055 
-Dtests.slow=true -Dtests.badapples=true -Dtests.locale=eu-ES 
-Dtests.timezone=Indian/Kerguelen -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII
   [junit4] ERROR   0.00s | AtomicUpdateProcessorFactoryTest (suite) <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: ObjectTracker found 6 
object(s) that were not released!!! [SolrCore, SolrIndexSearcher, 
MockDirectoryWrapper, MockDirectoryWrapper, SolrIndexSearcher, 
MockDirectoryWrapper]
   [junit4]    > 
org.apache.solr.common.util.ObjectReleaseTracker$ObjectTrackerException: 
org.apache.solr.core.SolrCore
   [junit4]    >        at 
org.apache.solr.common.util.ObjectReleaseTracker.track(ObjectReleaseTracker.java:42)
   [junit4]    >        at 
org.apache.solr.core.SolrCore.<init>(SolrCore.java:1093)
...



hossman@slate:~/lucene/dev/solr/core [j11] [c8203e4787b] $ cd ../../ && git co 
c8203e4787b8ad21e1270781ba4e09fd7f3acb00~1
Previous HEAD position was c8203e4787b SOLR-13728: fail partial updates to 
child docs when not supported.
HEAD is now at 2552986e872 LUCENE-8917: Fix Solr's TestCodecSupport to stop 
trying to use the now-removed Direct docValues format


hossman@slate:~/lucene/dev [j11] [2552986e872] $ ant clean && cd solr/core/ && 
ant test -Dtestcase=AtomicUpdateProcessorFactoryTest
...
common.test:

BUILD SUCCESSFUL
Total time: 1 minute 10 seconds



hossman@slate:~/lucene/dev/solr/core [j11] [2552986e872] $ ant test  
-Dtestcase=AtomicUpdateProcessorFactoryTest -Dtests.seed=9CA837338CB8D055 
-Dtests.slow=true -Dtests.badapples=true -Dtests.locale=eu-ES 
-Dtests.timezone=Indian/Kerguelen -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII
...
common.test:

BUILD SUCCESSFUL
Total time: 19 seconds
{noformat}

> Fail partial updates if it would inadvertently remove nested docs
> -----------------------------------------------------------------
>
>                 Key: SOLR-13728
>                 URL: https://issues.apache.org/jira/browse/SOLR-13728
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 8.3
>
>         Attachments: SOLR-13728.patch
>
>
> In SOLR-12638 Solr gained the ability to do partial updates (aka atomic 
> updates) to nested documents.  However this feature only works if the schema 
> meets certain circumstances.  We can know we don't support it and fail the 
> request – what I propose here.  This is much friendlier than wiping out 
> existing documents.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to