mikemccand commented on a change in pull request #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#discussion_r322794753
########## File path: lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java ########## @@ -89,12 +92,30 @@ */ public class LRUQueryCache implements QueryCache, Accountable { + /** Throw this error when a query is asynchronously being loaded in the cache + * and a read for the same is requested + */ + private static final class AsyncQueryLoadInProgressException extends RuntimeException { + + /** + * Sole constructor. + */ + public AsyncQueryLoadInProgressException(String query) { Review comment: Hmm why does this take `String query` not `Query query`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org