eribeiro commented on a change in pull request #864: SOLR-13101 : Shared storage support in SolrCloud URL: https://github.com/apache/lucene-solr/pull/864#discussion_r324023752
########## File path: solr/core/src/java/org/apache/solr/store/shared/SharedStoreManager.java ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.store.shared; + +import org.apache.solr.cloud.ZkController; +import org.apache.solr.store.blob.process.BlobDeleteManager; +import org.apache.solr.store.blob.process.BlobProcessUtil; +import org.apache.solr.store.blob.process.CorePullTracker; +import org.apache.solr.store.blob.provider.BlobStorageProvider; +import org.apache.solr.store.shared.metadata.SharedShardMetadataController; + +import com.google.common.annotations.VisibleForTesting; + +/** + * Provides access to Shared Store processes. Note that this class is meant to be + * more generic in the future and provide a cleaner API but for now we'll expose + * the underlying implementations + */ +public class SharedStoreManager { + + private ZkController zkController; + private SharedShardMetadataController sharedShardMetadataController; + private BlobStorageProvider blobStorageProvider; + private BlobDeleteManager blobDeleteManager; + private BlobProcessUtil blobProcessUtil; + private CorePullTracker corePullTracker; + + public SharedStoreManager(ZkController controller) { + zkController = controller; + // initialize BlobProcessUtil with the SharedStoreManager for background processes to be ready + blobProcessUtil = new BlobProcessUtil(zkController.getCoreContainer()); + } + + @VisibleForTesting + public void initBlobStorageProvider(BlobStorageProvider blobStorageProvider) { + this.blobStorageProvider = blobStorageProvider; + } + + /* + * Initiates a SharedShardMetadataController if it doesn't exist and returns one + */ + public SharedShardMetadataController getSharedShardMetadataController() { + if (sharedShardMetadataController != null) { Review comment: If this method (and the ones below) can be called by multiple threads then it can possibly hit a situation where two or more threads arrive at this line at the same time and `sharedShardMetadataController` is null and will create one or more objects. Does it make sense? Would it be the case of synchronizing the method? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
