Another easy powerful one. When you wait for state, you have to consider all the states you can actually see.
So like, if you are waiting for replicas and the shard is not even there yet, like you have to check getSlices==null, then keep waiting. Youcan't miss little things when waiting for the state you want to see. Go fix that and again, return will be huge for the effort. On Wed, Nov 6, 2019 at 10:34 AM Mark Miller <[email protected]> wrote: > Just like go look. Like your dog is limping and you check it out. You will > find fleas everywhere first, and then ticks, and then maybe some infection. > And it won't be hard at all. Just you caring for your dog and checking him > out cause he's limping. You will end up eating days at the vet, huge bills, > but it's no mind game to get there. > > On Wed, Nov 6, 2019 at 9:42 AM Mark Miller <[email protected]> wrote: > >> Really though, if you want to fix tests, start fixing the performance >> bottlenecks. >> >> Like being able to say solr.Class or just class in configs. That costs >> you your life, especially if you use more than one core. That speed trap >> alone hides enough bugs and grubs to make Pumbaa happy. >> >> On Wed, Nov 6, 2019 at 9:31 AM Mark Miller <[email protected]> wrote: >> >>> I mean honestly, if you just ignore me and fix the the smaller list of >>> critical things that affect like everything - that will make the system at >>> least look like it’s almost good. >>> >>> On Wed, Nov 6, 2019 at 9:22 AM Mark Miller <[email protected]> >>> wrote: >>> >>>> Like one of the biggest things those auth guys do is just raw response >>>> send error. Override our response where it does close shield and make it so >>>> those sendErrors actually just send a normal response format back to Solr >>>> with the proper error code instead of raw send error and closing the >>>> connection. Just that will help those security tests a lot. >>>> >>>> On Wed, Nov 6, 2019 at 9:19 AM Mark Miller <[email protected]> >>>> wrote: >>>> >>>>> You can still make progress this way. For example, all those like auth >>>>> type tests, you can fix them mostly by not closing connections in >>>>> solrdispatchfilter and waiting for collection creates, and maybe a >>>>> security >>>>> file in zk watcher thing. >>>>> >>>>> You can still make progress this way, you just prob won’t ever get to >>>>> the end of the road per say. >>>>> >>>>> On Mon, Nov 4, 2019 at 6:48 AM Erick Erickson <[email protected]> >>>>> wrote: >>>>> >>>>>> With all the discussion about major how broken Solr is, I’m not sure >>>>>> what the value of these is at this point, but they’re quick to do so what >>>>>> the heck. I probably won’t be changing annotations until that discussion >>>>>> reaches a conclusion. although I’ll continue to send these out. >>>>>> >>>>>> ********Failures in Hoss' reports for the last 4 rollups. >>>>>> >>>>>> There were 139 unannotated tests that failed in Hoss' rollups. >>>>>> Ordered by the date I downloaded the rollup file, newest->oldest. See >>>>>> above >>>>>> for the dates the files were collected >>>>>> These tests were NOT BadApple'd or AwaitsFix'd >>>>>> >>>>>> >>>>>> Failures in the last 4 reports.. >>>>>> Report Pct runs fails test >>>>>> 0123 3.5 912 48 >>>>>> BasicAuthIntegrationTest.testBasicAuth >>>>>> 0123 1.2 934 10 >>>>>> DimensionalRoutedAliasUpdateProcessorTest.testCatTime >>>>>> 0123 0.6 934 12 >>>>>> DimensionalRoutedAliasUpdateProcessorTest.testTimeCat >>>>>> 0123 3.4 939 71 >>>>>> LegacyCloudClusterPropTest.testCreateCollectionSwitchLegacyCloud >>>>>> 0123 0.6 906 6 >>>>>> MathExpressionTest.testGammaDistribution >>>>>> 0123 7.1 86 5 >>>>>> ShardSplitTest.testSplitWithChaosMonkey >>>>>> 0123 6.1 922 48 >>>>>> TestCloudSearcherWarming.testRepFactor1LeaderStartup >>>>>> 0123 6.1 936 75 >>>>>> TestModelManagerPersistence.testFilePersistence >>>>>> 0123 5.2 936 74 >>>>>> TestModelManagerPersistence.testWrapperModelPersistence >>>>>> 0123 2.8 903 20 >>>>>> TestSkipOverseerOperations.testSkipLeaderOperations >>>>>> ************ Will BadApple all tests above this line except ones >>>>>> listed at the top************** >>>>>> >>>>>> >>>>>> >>>>>> --------------------------------------------------------------------- >>>>>> To unsubscribe, e-mail: [email protected] >>>>>> For additional commands, e-mail: [email protected] >>>>> >>>>> -- >>>>> - Mark >>>>> >>>>> http://about.me/markrmiller >>>>> >>>> -- >>>> - Mark >>>> >>>> http://about.me/markrmiller >>>> >>> -- >>> - Mark >>> >>> http://about.me/markrmiller >>> >> >> >> -- >> - Mark >> >> http://about.me/markrmiller >> > > > -- > - Mark > > http://about.me/markrmiller > -- - Mark http://about.me/markrmiller
