Doesn't make sense to spend much time on such discussions, Erick, not at this early stage. If you like it -- leave it in, I have no problem with it whatsoever.
Dawid On Fri, Nov 15, 2019 at 6:02 PM Erick Erickson <[email protected]> wrote: > > Added SOLR-13935 for this general topic, please comment there if you’d rather. > > > On Nov 15, 2019, at 10:36 AM, Dawid Weiss <[email protected]> wrote: > > > >> Instead of a help.txt file though, how about some help task? ./gradlew > >> helpAnt? > > > > I don't think that's easier, to be honest. You need to know which task > > to invoke (and how). > > A plain file is just right there in your face. > > > >> it works just fine. Does this seem consistent with the structure of the > >> Gradle build? > > > > There is no one "structure" to a gradle build. There are some > > conventions but they're much more relaxed compared to Maven (or even > > ant). A gradle build is really just an arrangement of code blobs... > > how you write it is up to you. > > > > "../solr_gradle_8/help/build.gradle” to have a “help” prefix. > > helpTest, helpAnt, helpBuild (and, BTW, I really like that tasks > > aren’t case-sensitive). > > > > I personally don't like the fact you need to run gradle to display a > > text file... Mark added it at the beginning but I don't think it's > > really necessary. If you've done it already, so be it. > > > >> Here’s the diff, FYI. If this looks like it doesn’t do violence to the > >> structure of the gradle build I’ll check it in. > > > > It's fine I think. But again -- why pollute the build file with stuff > > that could be just a set of plain-text files (which people can display > > with anything they like)? Occam's razor -- the simplest method is > > typically the best. > > > > D. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
