Adrien, I've pushed a fix for that issue. The failure was probably due to usual flakiness, but hopefully you won't see the exception for that test that Dawid reported. I don't think it should be a blocker anymore (the other problem is that a test is trying to write data to source tree; I think that can be solved later).
On Mon, Dec 16, 2019 at 8:42 PM Adrien Grand <[email protected]> wrote: > > Could someone look at https://issues.apache.org/jira/browse/SOLR-14096 which > Dawid just opened? It looks to me like it should be a blocker? > > On Mon, Dec 16, 2019 at 1:55 PM Adrien Grand <[email protected]> wrote: >> >> I have to rebuild because of SOLR-14094, so I'll include SOLR-14087 too. >> >> On Mon, Dec 16, 2019 at 1:52 PM Ishan Chattopadhyaya >> <[email protected]> wrote: >>> >>> Hi Adrien, >>> I reverted one of the changes in SOLR-14087, and backported to 8.4 >>> branch. Apologies for the last moment change. >>> If RC1 goes out without this change, no worries and we'll deal with it >>> later. >>> Thanks and regards, >>> Ishan >>> >>> On Mon, Dec 16, 2019 at 3:50 PM Ishan Chattopadhyaya >>> <[email protected]> wrote: >>> > >>> > Hi Adrien, >>> > Let's push it to 8.5. >>> > +1 to proceed for RC1. >>> > Thanks, >>> > Ishan >>> > >>> > On Mon, 16 Dec, 2019, 2:07 PM Adrien Grand, <[email protected]> wrote: >>> >> >>> >> Among the various JIRAs mentioned above, it looks like only >>> >> https://issues.apache.org/jira/browse/SOLR-14066 is not in yet. Please >>> >> let me know if there are other JIRAs that you are thinking of getting it >>> >> that have not been pushed yet, but in general I'd like to start pushing >>> >> changes to 8.5 whenever possible to avoid delaying the release too much. >>> >> >>> >> On Sun, Dec 15, 2019 at 1:17 PM Noble Paul <[email protected]> wrote: >>> >>> >>> >>> I plan to commit the following as well. >>> >>> It's just a precautionery measure to avoid any future exploits >>> >>> https://github.com/apache/lucene-solr/pull/1085 >>> >>> >>> >>> On Sun, Dec 15, 2019 at 4:32 PM Ishan Chattopadhyaya >>> >>> <[email protected]> wrote: >>> >>> > >>> >>> > I've added a few critical fixes for SOLR-13662 to the branch. I tested >>> >>> > them thoroughly and got reviews for the fixes from Jan, Noble and >>> >>> > Eduardo. >>> >>> > >>> >>> > On Sun, Dec 15, 2019 at 5:18 AM Adrien Grand <[email protected]> >>> >>> > wrote: >>> >>> > > >>> >>> > > Hi Kevin, >>> >>> > > >>> >>> > > I'll defer to your judgement regarding whether this is safe to get >>> >>> > > in 8.4. >>> >>> > > >>> >>> > > Le sam. 14 déc. 2019 à 21:00, Kevin Risden <[email protected]> a >>> >>> > > écrit : >>> >>> > >> >>> >>> > >> Tim found SOLR-14086 which looks like a test only dependency >>> >>> > >> leaking into compile caused by SOLR-14033. I put a patch up. I >>> >>> > >> won't get to get it until later tonight or tomorrow ~24hrs from >>> >>> > >> now. >>> >>> > >> >>> >>> > >> This causes any Solr Tika usage with 7z or a few other compressed >>> >>> > >> file types (depends if they use commons-compress) to fail due to >>> >>> > >> different classloaders being used. >>> >>> > >> >>> >>> > >> Kevin Risden >>> >>> > >> >>> >>> > >> >>> >>> > >> On Sat, Dec 14, 2019 at 2:09 PM Jan Høydahl >>> >>> > >> <[email protected]> wrote: >>> >>> > >>> >>> >>> > >>> Deprecation of DIH is ready for review >>> >>> > >>> https://issues.apache.org/jira/browse/SOLR-14066 >>> >>> > >>> One code change which is a WARN log at startup, other changes are >>> >>> > >>> documentation. >>> >>> > >>> >>> >>> > >>> Low risk and we’d like to deprecate sooner rather than later in >>> >>> > >>> 8.x. Your call Adrien. >>> >>> > >>> >>> >>> > >>> Jan >>> >>> > >>> >>> >>> > >>> 13. des. 2019 kl. 10:03 skrev Adrien Grand <[email protected]>: >>> >>> > >>> >>> >>> > >>> Let's get that one in as well, thanks Yonik. >>> >>> > >>> >>> >>> > >>> On Fri, Dec 13, 2019 at 2:26 AM Yonik Seeley <[email protected]> >>> >>> > >>> wrote: >>> >>> > >>>> >>> >>> > >>>> Heads up on https://issues.apache.org/jira/browse/SOLR-14079 >>> >>> > >>>> Bad bug (autoscale triggers use async, so splitByPrefix does not >>> >>> > >>>> work.) . The fix is super simple and very low risk since it's >>> >>> > >>>> encapsulated within the block only used when splitByPrefix=true. >>> >>> > >>>> >>> >>> > >>>> -Yonik >>> >>> > >>>> >>> >>> > >>> >>> >>> > >>> >>> >>> > >>> -- >>> >>> > >>> Adrien >>> >>> > >>> >>> >>> > >>> >>> >>> > >>> >>> > --------------------------------------------------------------------- >>> >>> > To unsubscribe, e-mail: [email protected] >>> >>> > For additional commands, e-mail: [email protected] >>> >>> > >>> >>> >>> >>> >>> >>> -- >>> >>> ----------------------------------------------------- >>> >>> Noble Paul >>> >>> >>> >>> --------------------------------------------------------------------- >>> >>> To unsubscribe, e-mail: [email protected] >>> >>> For additional commands, e-mail: [email protected] >>> >>> >>> >> >>> >> >>> >> -- >>> >> Adrien >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> >> -- >> Adrien > > > > -- > Adrien --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
