No, it did not fail for me locally. I tracked it from failing build in a PR I had raised.
On Wed, 24 Jun 2020 at 18:51, Erick Erickson <[email protected]> wrote: > Cool. You want to take over SOLR-14591 then? Or mark it as duplicate if > you already have one. > > Curiosity question: Did you have gradlew check or precommit fail locally? > Because I’m puzzled why > it doesn’t fail locally for me. > > Erick > > > On Jun 24, 2020, at 9:00 AM, Erick Erickson (Jira) <[email protected]> > wrote: > > > > Erick Erickson created SOLR-14591: > > ------------------------------------- > > > > Summary: Move JoinQuery in JoinQParserPlugin to its own class > > Key: SOLR-14591 > > URL: https://issues.apache.org/jira/browse/SOLR-14591 > > Project: Solr > > Issue Type: Sub-task > > Reporter: Erick Erickson > > Assignee: Erick Erickson > > > > > > Not sure why this isn't being flagged as a warning in master, but it did > cause an error on a Jenkins build, there's no reason NOT to fix it. > > > > > > > > -- > > This message was sent by Atlassian Jira > > (v8.3.4#803005) > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Regards, Atri Apache Concerted
