Just for a supplement...

> Then I don't understand the discussion between you and some committers
who did not run "gradlew" and used "gradle" instead. Where was the issue
then?

I think the original motivation/point of this thread is "how to prevent
newdevs (gradle newbies) from using 'gradle', instead prompt them to use
'gradlew'"... None of us want to use 'gradle' so there is no issue at all
for us, committers.

I'll plan to add these notes to the top-level README for "newdevs" by this
patch: https://github.com/apache/lucene-solr/pull/1835/files
========
NOTE: DO NOT use `gradle` command that is already installed on your machine
(unless you know what you'll do).
The "gradle wrapper" does the job - download the correct version of it,
setup necessary configurations.
========
Yes it's an obvious thing and may be a tedious explanation for experienced
Java developers, but I'd agree that such wordy notes are sometimes helpful
for new (maybe junior) developers.

Hope it helps.

Tomoko


2020年9月7日(月) 7:04 Uwe Schindler <[email protected]>:

> Hi,
>
> > > Enforcing version and gradlew vs local shouldn't be difficult.
> >
> > We already enforce the version:
> >
> https://github.com/dweiss/lucene-solr/blob/master/gradle/validation/check-
> > environment.gradle#L42-L45
> >
> > If you run a non-wrapper gradle (local) or via gradlew does not matter
> > as long as it's the same exact version. but this is nearly impossible
> > to achieve if you
> > work on more than one project (or even one project with multiple
> > branches, each having a different gradle version...). This enforcement
> > is really there to protect
> > you from hours of debugging nonsensical errors caused by
> > incompatibilities within gradle itself. We could allow other versions
> > (or version ranges) but it's an additional
> > overhead for someone to maintain -- I'm personally not interested in
> > doing that, honestly.
>
> Oh thanks, was not aware of that. Then I don't understand the discussion
> between you and some committers who did not run "gradlew" and used "gradle"
> instead. Where was the issue then?
>
> If the version is identical, then there's no issue at all.
>
> Uwe
>
>

Reply via email to