Hey Jan, thanks for the review. I hadn't thought about the V2 API in connection to this work. You're right though I think - the SIP proposes net-new APIs, so it should add V2 equivalents at the very least. I'll draft tentative details for these APIs on the SIP and we can refine things from there.
I'm more up in the air on your specific suggestion to restrict the SIP changes to these v2 APIs. It is an elegant approach to the backcompat, and it provides a carrot for v2 adoption - both of which I like. But it would let users create snapshot-based backups (and keep us maintaining that code) longer than there's any strict need to. And users are left on the less-efficient format by default. (By contrast, the current SIP has snapshot-backup creation being replaced by incremental-backup creation as soon as the latter is available.). Did you have a particular lifespan in mind for snapshot-based creation if we go with this approach? Jason On Thu, Dec 17, 2020 at 3:54 PM Jan Høydahl <[email protected]> wrote: > > Much needed! Thanks for initiating this Jason! > > As we want to move away from v1 APIs where a HTTP GET is used for creation > and deletion, would it be an idea to leave the old backup/resotre APIs as-is, > and implement the new imporved version as a V2-api only, and then deprecate > the v1 API? Then we don't need to worry about back-compat, and we get a > head-start on converting the COLLECTION API to v2 style. > > Jan > > > 15. des. 2020 kl. 15:48 skrev Jason Gerlowski <[email protected]>: > > > > Hey all, > > > > This morning I published SIP-12, which proposes an overhaul of Solr's > > backup and restore functionality. While the "headline" improvement in > > this SIP is a change to do backups incrementally, it bundles in a > > number of other improvements as well, including the addition of > > corruption checks, APIs to list and delete backups, and stronger > > integration points with popular object storage APIs. > > > > The SIP can be found here: > > https://cwiki.apache.org/confluence/display/SOLR/SIP-12%3A+Incremental+Backup+and+Restore > > > > Please read the SIP description and come back here for discussion. As > > the discussion progresses we will update the SIP page with any > > outcomes and eventually move things to a VOTE. > > > > Looking forward to hearing your feedback. > > > > Best, > > > > Jason > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
